Skip to content

Comments

add energy and id to i05-shared#1921

Merged
Villtord merged 9 commits intomainfrom
add_apple_knot_to_i05
Feb 20, 2026
Merged

add energy and id to i05-shared#1921
Villtord merged 9 commits intomainfrom
add_apple_knot_to_i05

Conversation

@Villtord
Copy link
Contributor

@Villtord Villtord commented Feb 13, 2026

Add energy and insertion device control (AppleKnot) for i05 beamline.
Fixes DiamondLightSource/sm-bluesky#259

Instructions to reviewer on how to test:

  1. Do dodal connect i05 and dodal connect i05-1
  2. Confirm tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@Villtord Villtord self-assigned this Feb 13, 2026
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (fb60cba) to head (beb805c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1921   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files         312      314    +2     
  Lines       11732    11775   +43     
=======================================
+ Hits        11621    11664   +43     
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Villtord Villtord marked this pull request as ready for review February 13, 2026 14:59
@Villtord Villtord requested a review from a team as a code owner February 13, 2026 14:59
@Villtord Villtord enabled auto-merge (squash) February 20, 2026 10:59
@Villtord Villtord merged commit fd21a9e into main Feb 20, 2026
7 checks passed
@Villtord Villtord deleted the add_apple_knot_to_i05 branch February 20, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I05 energy devices

2 participants